From: Andrzej Hajda Date: Tue, 1 Mar 2016 09:36:23 +0000 (+0100) Subject: iommu/mediatek: Fix handling of of_count_phandle_with_args result X-Git-Tag: archive/raspbian/4.9.13-1+rpi1~10^2~2659^2^5~1 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/www.github.com/%22bookmarks:///%22http:/www.example.com/cgi/%22https:/www.github.com/%22bookmarks:/?a=commitdiff_plain;h=0b6c0ad3cfe6bc914af3ae595c9729e38f11a024;p=linux-4.9.git iommu/mediatek: Fix handling of of_count_phandle_with_args result The function can return negative value so it should be assigned to signed variable. The patch changes also type of related i variable to make code more compact and coherent. The problem has been detected using patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. Signed-off-by: Andrzej Hajda Signed-off-by: Joerg Roedel --- diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index f3c160e4c25d..4b9ae64c2fc3 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -578,8 +578,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) struct resource *res; struct component_match *match = NULL; void *protect; - unsigned int i, larb_nr; - int ret; + int i, larb_nr, ret; data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); if (!data)